Skip to content

Include missing "dont-cleanup-after-each" script in npm package #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ndresx
Copy link
Contributor

@ndresx ndresx commented Oct 26, 2019

What:

This adds the currently missing dont-cleanup-after-each.js file reference in package.json so that npm can pick it up and ship it within an upcoming release.

Why:

According to the docs (https://react-hooks-testing-library.com/reference/api#cleanup), it should be possible to set up this script via Jest config, but the file doesn't exist in the current package version (https://www.unpkg.com/browse/@testing-library/[email protected]/).

It also removes the redundant README.md and LICENSE.md from the files list as they are always included on npm publish (https://docs.npmjs.com/files/package.json#files).

Checklist:

  • Ready to be merged

@codecov
Copy link

codecov bot commented Oct 26, 2019

Codecov Report

Merging #208 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #208   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          56     56           
  Branches        5      5           
=====================================
  Hits           56     56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437cda5...47f045a. Read the comment docs.

@mpeyper
Copy link
Member

mpeyper commented Oct 26, 2019

Wow. Whoops!

Thanks for spotting that and fixing it!

@mpeyper mpeyper merged commit 53c50ba into testing-library:master Oct 26, 2019
@ndresx ndresx deleted the include-dont-cleanup-after-each-pkg-script branch October 26, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants