Skip to content

Fix example #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Fix example #47

merged 1 commit into from
Apr 22, 2019

Conversation

josepot
Copy link
Contributor

@josepot josepot commented Apr 22, 2019

What:

I've fixed the code of the main example.

Why:

Because as I explain in this post, the custom-hook of the main example wouldn't work correctly otherwise.

How:

I just used the function overload of setState.

Checklist:

Yep

  • Documentation updated
  • Ready to be merged
  • Added myself to contributors table

@codecov-io
Copy link

codecov-io commented Apr 22, 2019

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #47   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          44     44           
  Branches        4      4           
=====================================
  Hits           44     44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4d3d2...68cca1c. Read the comment docs.

@mpeyper
Copy link
Member

mpeyper commented Apr 22, 2019

Nice observation.

@mpeyper mpeyper merged commit 23486b5 into testing-library:master Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants