Skip to content

fix(cleanup-after-each): remove cleanup-after-each file. #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

kentcdodds
Copy link
Member

@kentcdodds kentcdodds commented Aug 9, 2019

What: remove cleanup-after-each file.

Why: This is automatic now, so there is no reason to have it

How: Remove all the related files and the entry in package.json files array.

Checklist:

  • Documentation added to the
    docs site - Will do this soon
  • Tests
  • Typescript definitions updated N/A
  • Ready to be merged

Closes #432

This is automatic now, so there is no reason to have it
@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #433 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #433   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      3    -1     
  Lines          95     90    -5     
  Branches       13     13           
=====================================
- Hits           95     90    -5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd6544...8e9562f. Read the comment docs.

@kentcdodds kentcdodds merged commit 0b83ca5 into master Aug 9, 2019
@kentcdodds kentcdodds deleted the pr/remove-cleanup-after-each branch August 9, 2019 20:13
@kentcdodds
Copy link
Member Author

🎉 This PR is included in version 9.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@danielkcz
Copy link
Contributor

I think you went too fast with that, could have been at least deprecated to be removed in next major. It's a relatively small thing but adds unnecessary overhead to upgrading.

@danielkcz
Copy link
Contributor

Deprecation warning would also teach people about the feature in case someone is not reading release notes too carefully.

@kentcdodds
Copy link
Member Author

You're right. I'll add it back with a deprecation warning.

@kentcdodds
Copy link
Member Author

Publishing the fix now. I was hasty. Thanks for calling me out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove cleanup-after-each
2 participants