-
Notifications
You must be signed in to change notification settings - Fork 724
docs(solid-testing-library): add solid testing library docs #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(solid-testing-library): add solid testing library docs #1370
Conversation
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7b7a1a8
to
88e4644
Compare
88e4644
to
2b4d5e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good I did leave a few remarks/questions but these are more suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's amazing, thank you so much @danieljcafonso!
I've left a few minor comments.
Co-authored-by: Tim Deschryver <[email protected]>
Co-authored-by: Matan Borenkraout <[email protected]>
Co-authored-by: Matan Borenkraout <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM!
I'll leave this open for @MatanBobi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danieljcafonso! Super excited for this one.
Added a Solid Testing Library section!
Note: this is mostly a port of https://github.com/solidjs/solid-testing-library current docs. Please let me know if changes are needed :)
Closes #1364