Skip to content

docs(solid-testing-library): add solid testing library docs #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

danieljcafonso
Copy link
Contributor

Added a Solid Testing Library section!

Note: this is mostly a port of https://github.com/solidjs/solid-testing-library current docs. Please let me know if changes are needed :)

Closes #1364

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit 6e996e8
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/65e89c5e2c9668000859fe6c
😎 Deploy Preview https://deploy-preview-1370--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danieljcafonso danieljcafonso force-pushed the docs(solid-testing-library) branch from 7b7a1a8 to 88e4644 Compare February 20, 2024 12:38
@danieljcafonso danieljcafonso changed the title docs(solid-testing-library): add solid testing library docs(solid-testing-library): add solid testing library docs Feb 20, 2024
@danieljcafonso danieljcafonso force-pushed the docs(solid-testing-library) branch from 88e4644 to 2b4d5e6 Compare February 20, 2024 12:43
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I did leave a few remarks/questions but these are more suggestions.

Copy link
Member

@MatanBobi MatanBobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's amazing, thank you so much @danieljcafonso!
I've left a few minor comments.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM!
I'll leave this open for @MatanBobi

Copy link
Member

@MatanBobi MatanBobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danieljcafonso! Super excited for this one.

@MatanBobi MatanBobi merged commit 0e8a058 into testing-library:main Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add solid-testing-library to docs
3 participants