fix: replace the TabItem values with general ones #1394
Conversation
Replace the TabItem values with general ones, because if you select a tab in one of the code examples, TypeScript, then other examples change asynchronously (i.e. the code examples will remain in JavaScript, or vice versa).
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks @Efim-Kapliy but I'm not sure I'm following. Currently if a user changes a tab, the rest change accordingly. What is this PR aiming to solve? |
|
Okay, now I'm going to try to explain with illustrative examples. This is the option that is currently displayed asynchronously: The expected, synchronous option: I think it will be more understandable. |
|
Thanks, I was under the impression that these already work. Edit: I understand now. We have one item with values of js/ts and two with values of jsx/tsx. Since these don't really affect the code styling as it's done in the markdown, were good with merging this. |
|
Yes, that's right. |
There was a problem hiding this comment.
This looks good to me (I had to check 3-4 times to see understand what changed though 😅)!
Thanks for the PR.
Do you want to align it across the entire docs?
I verified that this page is the only place where we use these tab items (with ts(x) and js(x)) ~ the other pages use the name of the TL (react, angular, ...)
|
@all-contributors please add @Efim-Kapliy for docs |
|
I've put up a pull request to add @Efim-Kapliy! 🎉 |
It will be easier for the user if you replace the TabItem values with general ones, because if you select a tab in one of the code examples, TypeScript, then other examples change asynchronously (i.e. the code examples will remain in JavaScript, or vice versa).