feat(plugin): settings-ui #3066
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: 2 weeks have passed w/o any message, so I'll continue with whatever I think looks best. |
…usic into feat/settings-ui
JellyBrick
requested changes
Mar 26, 2025
| close: () => void; | ||
| } | ||
|
|
||
| export default ({ close }: SettingsModalProps) => { |
There was a problem hiding this comment.
In Solid.js, you should not use object destructuring on props. If you destructure props, you will lose reactivity.
There was a problem hiding this comment.
Yeah I know, I just don't have reactive values in that specific instance
There was a problem hiding this comment.
ig it is good practice to not destructure the props anywhere, just for the sake of being consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This is a plugin that introduces a new settings interface!
Configuring everything through menu options is not only a pain, but it is also a pain! (double pain!)
I propose that this plugin is enabled by default, but I won't insist on that if you think otherwise.
TODO
Screenshots