Skip to content

fix links and commands #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix links and commands #7

merged 1 commit into from
Jun 6, 2023

Conversation

IsQiao
Copy link
Contributor

@IsQiao IsQiao commented Jun 6, 2023

Fix some error links and commands

squat
squat reviewed Jun 6, 2023
View reviewed changes
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IsQiao :))
Can you please sign the DCO and then we can merge?

Govt
Hint: git commit --amend --signoff

@IsQiao
Copy link
Contributor Author

IsQiao commented Jun 6, 2023

Thanks @IsQiao :)) Can you please sign the DCO and then we can merge?

Govt Hint: git commit --amend --signoff

fixed it.

@squat
Copy link
Member

squat commented Jun 6, 2023

It looks like it's still failing. Is it possible that you signed with the wrong email address?

@IsQiao
fixed links and commands
9fa2c79 
Signed-off-by: qinxiaowen <[email protected]>
@IsQiao
Copy link
Contributor Author

IsQiao commented Jun 6, 2023

fixed it.

@squat
Copy link
Member

squat commented Jun 6, 2023

Thanks :)

@squat squat merged commit e43900e into thanos-io:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IsQiao @squat