API feature: return existing link with error on creation #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return the existing link record and 409 status code when trying to create with a customurl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this awesome project!
This PR adds a simple feature to the link creation API endpoint: returns the existing link item together with the error message and sets the status code to 409.
My use case is that I need to update the target address while keeping the customurl unchanged, given only the customurl is known. While the feature of this PR achieves my goal, but I have to get it done with two requests (get the id from the error message and update the existing record using the id).
Please let me know if there're similar use cases so I might continue with more complex solutions like "create or update" which could get the job done in single request.