-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling Suspend may trigger an assert in SentinelDrawCallback() #255
Comments
thedmd
added a commit
that referenced
this issue
Sep 19, 2023
thedmd
added a commit
that referenced
this issue
Sep 19, 2023
thedmd
added a commit
that referenced
this issue
Sep 19, 2023
thedmd
added a commit
that referenced
this issue
Sep 19, 2023
@pthom Should be fixed now. Can you confirm it does work for you? |
Hi Michał, I confirm the fix works perfectly! Thanks! |
Hi @thedmd, would you mind creating a bugfix release for this? Currently the vcpkg port in microsoft/vcpkg repo has the v0.9.2 which is affected by this, it would be great to upgrade it with proper release instead of just commit SHA |
@helynranta I did pulish v0.9.3, hope that helps. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I just updated to the latest commit on the develop branch, and I have an issue when calling Suspend and Resume.
Basically,
SentinelDrawCallback
may be called and will trigger an assert.This happens when the code inside Suspend/Resume opens an additional window.
I prepared a minimal repro here:
https://github.com/pthom/node_window_clipping_issue/tree/suspend_resume_issue
(be sure to use the "suspend_resume_issue branch).
I also prepared a quick video explanation here: https://traineq.org/poub/node_editor_issue_suspend.mp4 (1 minute)
Thanks!
The text was updated successfully, but these errors were encountered: