Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling Suspend may trigger an assert in SentinelDrawCallback() #255

Closed
pthom opened this issue Sep 12, 2023 · 4 comments
Closed

Calling Suspend may trigger an assert in SentinelDrawCallback() #255

pthom opened this issue Sep 12, 2023 · 4 comments
Assignees

Comments

@pthom
Copy link

pthom commented Sep 12, 2023

Hi,

I just updated to the latest commit on the develop branch, and I have an issue when calling Suspend and Resume.
Basically, SentinelDrawCallback may be called and will trigger an assert.
This happens when the code inside Suspend/Resume opens an additional window.

I prepared a minimal repro here:

https://github.com/pthom/node_window_clipping_issue/tree/suspend_resume_issue

(be sure to use the "suspend_resume_issue branch).

I also prepared a quick video explanation here: https://traineq.org/poub/node_editor_issue_suspend.mp4 (1 minute)

Thanks!

@thedmd
Copy link
Owner

thedmd commented Sep 19, 2023

@pthom Should be fixed now. Can you confirm it does work for you?

@thedmd thedmd closed this as completed Sep 19, 2023
@pthom
Copy link
Author

pthom commented Sep 19, 2023

Hi Michał,

I confirm the fix works perfectly! Thanks!

@helynranta
Copy link

Hi @thedmd, would you mind creating a bugfix release for this? Currently the vcpkg port in microsoft/vcpkg repo has the v0.9.2 which is affected by this, it would be great to upgrade it with proper release instead of just commit SHA

@thedmd
Copy link
Owner

thedmd commented Oct 14, 2023

@helynranta I did pulish v0.9.3, hope that helps. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants