-
-
Notifications
You must be signed in to change notification settings - Fork 454
ToggleSwitch simplified #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Hi! I'm picking up this issue |
andreaTarascioSophany
added a commit
to SophanySC/flowbite-react-sophany
that referenced
this issue
Aug 23, 2023
ToggleSwitch optional props themesberg#925
1 task
rluders
pushed a commit
that referenced
this issue
Sep 21, 2023
* refactor(toggleswitch.tsx): toggleSwitch optional props ToggleSwitch optional props #925 * refactor(better sintax): improved quality of code improved quality of code
2 tasks
Still missing the |
maman
pushed a commit
to transkripid/flowbite-react
that referenced
this issue
Oct 7, 2023
* refactor(toggleswitch.tsx): toggleSwitch optional props ToggleSwitch optional props themesberg#925 * refactor(better sintax): improved quality of code improved quality of code
1 task
Unless we make it have internal state (or have the Or we provide |
Fixed by #1498 in [email protected] release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
The ToggleSwitch component is requiring always parameters that are not always being to be used.
Request: change to optional some of them.
Context
I am creating a form just to visualize information, and due to the screen design, I cannot use the embedded label, but it is mandatory to define one.
As it is only for information, it is not going to change, but the onChange function is also mandatory.
Example: I have to implement this design using
label=""
andonChange={() => {}}
and generating unnecessary warnings in my code.The text was updated successfully, but these errors were encountered: