-
-
Notifications
You must be signed in to change notification settings - Fork 454
perf(component treeshaking): updated config and build files to treesh… #1218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ake single components Each component now is treeshshaken individually into the final build BREAKING CHANGE: How import components themesberg#1197
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…references on exports" Exporting components from index to maintain legacy code usable, added optional individual exports as /components
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1218 +/- ##
==========================================
- Coverage 99.54% 97.36% -2.18%
==========================================
Files 163 214 +51
Lines 6621 9077 +2456
Branches 401 530 +129
==========================================
+ Hits 6591 8838 +2247
- Misses 30 239 +209 ☔ View full report in Codecov by Sentry. |
Will be implemented in the next version of the monorepo -> next release |
The approach is OK, think it solves partially the reported issue of #1197.
@SutuSebastian is this fix you are mentioning part of 7.3? What version will the fix be in? Is there a PR of the fix you mentioned? |
There is a PR on it, its #1264, almost done. |
Fixed in #1264 |
Each component can now OPTIONALLY be imported individually from the components path.
EXAMPLE:
Components with old pattern:
Will still work, but will still treeshake hell as well.
PS: This pr will not fix the themes treeshaking which seems to be more complex.
#1197
Keen to hear back from the maintainers.
FINAL BUILD RESULT with "/components":

FINAL BUILD RESULT w/out "/components":
