Skip to content

fix(datepicker): button type #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

rluders
Copy link
Collaborator

@rluders rluders commented Sep 22, 2023

The buttons inside Datepicker must be type button not to submit the form when action over it.

Fixes: #976

If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 2:15pm

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 71.48% and project coverage change: -6.09% ⚠️

Comparison is base (7461173) 99.54% compared to head (c25876c) 93.46%.
Report is 86 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #984      +/-   ##
==========================================
- Coverage   99.54%   93.46%   -6.09%     
==========================================
  Files         163      182      +19     
  Lines        6621     7895    +1274     
  Branches      401      439      +38     
==========================================
+ Hits         6591     7379     +788     
- Misses         30      516     +486     
Files Changed Coverage Δ
src/components/Pagination/helpers.ts 100.00% <ø> (ø)
src/components/Toast/theme.ts 100.00% <ø> (ø)
src/components/Datepicker/Datepicker.tsx 28.00% <28.00%> (ø)
src/components/Datepicker/Views/Days.tsx 36.00% <36.00%> (ø)
src/components/Datepicker/Views/Decades.tsx 37.70% <37.70%> (ø)
src/components/Datepicker/Views/Months.tsx 37.70% <37.70%> (ø)
src/components/Datepicker/Views/Years.tsx 37.70% <37.70%> (ø)
src/components/Banner/BannerCollapseButton.tsx 40.90% <40.90%> (ø)
src/components/Datepicker/helpers.ts 60.13% <60.13%> (ø)
src/components/Banner/Banner.tsx 64.70% <64.70%> (ø)
... and 45 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SutuSebastian SutuSebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rluders rluders force-pushed the fix/datapicker-button branch from 0f213f4 to c25876c Compare September 22, 2023 14:08
@rluders rluders merged commit 496ed1e into themesberg:main Sep 22, 2023
@rluders rluders deleted the fix/datapicker-button branch September 22, 2023 14:13
maman pushed a commit to transkripid/flowbite-react that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datepicker buttons submitting the form
2 participants