(feature) Disable version header in relay proxy #3140
Assignees
Labels
Comments
tomflenner
added
enhancement
|
/assign-me |
|
👋 Hey @tomflenner, this issue is already assigned to @thomaspoignant. 🔧 A maintainer can also add you to the list of assignees or swap you with the current assignee. |
thomaspoignant
added
p2
|
/assign-me |
|
👋 Hey @tomflenner, thanks for your interest in this issue! 🎉 ⚠ Note that this issue will become unassigned if it isn't closed within 20 days. 🔧 A maintainer can also add the 📌 Pinned label to prevent it from being unassigned automatically. |
tomflenner
pushed a commit
to tomflenner/go-feature-flag
that referenced
this issue
Feb 24, 2025
add a boolean EnableVersionHeader in configuration to conditionnally register the VersionHeader custom middleware and disable the header x-gofeatureflag-version issue: thomaspoignant#3140
tomflenner
pushed a commit
to tomflenner/go-feature-flag
that referenced
this issue
Feb 24, 2025
add a boolean EnableVersionHeader in configuration to conditionnally register the VersionHeader custom middleware and disable the header x-gofeatureflag-version issue: thomaspoignant#3140
tomflenner
pushed a commit
to tomflenner/go-feature-flag
that referenced
this issue
Feb 24, 2025
add a boolean EnableVersionHeader in configuration to conditionnally register the VersionHeader custom middleware and disable the header x-gofeatureflag-version issue: thomaspoignant#3140
4 tasks
tomflenner
pushed a commit
to tomflenner/go-feature-flag
that referenced
this issue
Feb 24, 2025
add a boolean DisableVersionHeader in configuration with Skipper on the VersionHeader middleware to issue: thomaspoignant#3140
tomflenner
pushed a commit
to tomflenner/go-feature-flag
that referenced
this issue
Feb 24, 2025
add a boolean EnableVersionHeader in configuration to conditionnally register the VersionHeader custom middleware and disable the header x-gofeatureflag-version issue: thomaspoignant#3140
tomflenner
pushed a commit
to tomflenner/go-feature-flag
that referenced
this issue
Feb 24, 2025
add a boolean DisableVersionHeader in configuration with Skipper on the VersionHeader middleware to issue: thomaspoignant#3140
kodiakhq bot
pushed a commit
that referenced
this issue
Feb 25, 2025
* feat(relayproxy): allow disable VersionHeader middleware add a boolean EnableVersionHeader in configuration to conditionnally register the VersionHeader custom middleware and disable the header x-gofeatureflag-version issue: #3140 * feat(relayproxy): allow disable VersionHeader middleware add a boolean DisableVersionHeader in configuration with Skipper on the VersionHeader middleware to issue: #3140 * docs(relayproxy): add disableVersionHeader to documentation * feat(relayproxy): fix linter with non used parameter in Skipper * nit pick to be more idiomatic Signed-off-by: Thomas Poignant <[email protected]> --------- Signed-off-by: Thomas Poignant <[email protected]> Co-authored-by: Tom Flenner <[email protected]> Co-authored-by: Thomas Poignant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Requirements
Hello !
We're using RelayProxy in production since several month now and our OPS teams reported that the
x-gofeatureflag-versionheader was forward in HTTP requests. It would be nice to not have to tweak our Kong gateway to remove this header and let the component himself do it. Our team don't want to expose infrastructure concern inside the HTTP request for some reason.After discussing with @thomaspoignant, this header is used to detect GOFF version and disable some feature in the provider for compatibility reason. At the moment he never needed to use this feature.
I suggest to allow users to deactivate this header from configuration to be more flexible on relay proxy usage.
The text was updated successfully, but these errors were encountered: