fix(tracing): Restore OTel tracing support #2482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1503, the code that used to call
s.otelService.Init
was accidentally removed. This restores that code.Here's proof of spans once again being sent to a local Alloy/Tempo setup:
Note that I have not written a unit test to cover this, as it's quite difficult to do so with how the OTel SDK is configured currently.
I have some ideas on how tracing support can be made more flexible (through use of
autoexport
primarily, and some other changes). I'll issue a PR for that some other time.Closes issue(s)
Fixes #2479
Checklist
README.md
and/website/docs
)