Skip to content

Fix 525: ff.RawVariation not working with default value as nil #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

thomaspoignant
Copy link
Owner

Description

ff.RawVariation not working with default value as nil.
This PR allow to have nil as default value.

Changes include

  • Bugfix (non-breaking change that solves an issue)

Closes issue(s)

Resolve #525

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for go-feature-flag-doc-preview ready!

Name Link
🔨 Latest commit 8a0b42b
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/63f502a4ecc83c000767179b
😎 Deploy Preview https://deploy-preview-526--go-feature-flag-doc-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #526 (8a0b42b) into main (3108ae3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #526   +/-   ##
=======================================
  Coverage   90.37%   90.37%           
=======================================
  Files          51       51           
  Lines        2202     2202           
=======================================
  Hits         1990     1990           
  Misses        168      168           
  Partials       44       44           
Impacted Files Coverage Δ
variation.go 98.13% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug) ff.RawVariation not working with default value as nil
1 participant