Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negative lookahead to tokenizer #130

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Add negative lookahead to tokenizer #130

merged 4 commits into from
Apr 1, 2024

Conversation

nachobibian
Copy link
Contributor

@nachobibian nachobibian commented Nov 7, 2023

Words that start with numbers (such as GUIDs) are not well processed by the tokenizer.

Furthermore the output of stringify is not understood by parse.

const str = stringify({
  op: "eq",
  attrPath: "064869bf-be25-466f-803d-004a0540574b",
  compValue: "bjensen"
})

console.log(parse(str)) // throws

Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@thomaspoignant
Copy link
Owner

Hey @nachobibian sorry for the time it took to review your PR.
Thanks a lot for your contribution, I will release a new version of the lib soon.

@thomaspoignant thomaspoignant merged commit e989459 into thomaspoignant:master Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants