fix stringfy #92
Merged
fix stringfy #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomaspoignant Hi, could you please take a look at this minor fix whenever you get a chance? thanks |
|
@shaneshen-okta thanks for your pull request I am on PTO and don't have access to a computer until next week. I will have a look as soon as I am back and release a new version based on that. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@thomaspoignant sure, have fun. |
|
@thomaspoignant No mean to rush. just a gentle reminder on this PR in case you forget. thanks |
|
I have released a new version with this fix. |
|
@thomaspoignant that's awesome. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔴
stringfydose NOT return correct string for certain filters, see test case✅ clean
stringfyand add fix