feat: support sub-attributes after value paths. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow comparison operations on sub-attributes following value paths. e.g. `emails[type eq "work"].value eq "[email protected]"` The tokenizer regex was updated to allow for a trailing dot (.) after a closing square bracket (]) when searching for "Bracket" tokens. `readValFilter` was then updated to look for any dot after the closing bracket and a following "Word" token. When this happens an implicit `and` op is returned. One issue with this approach is that any `and` ops before or after this syntax will result in nested `and` ops instead of a single op with more than two filters. Check the last test added to `parse.test.ts` for an example. However, I couldn't figure out a neat way to flattening that use case without a much more disruptive changeset. fixes: thomaspoignant#96
|
Kudos, SonarCloud Quality Gate passed!
|
|
thanks a lot @mastermatt for this contribution, this is super helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow comparison operations on sub-attributes following value paths. e.g.
emails[type eq "work"].value eq "[email protected]"The tokenizer regex was updated to allow for a trailing dot (.) after a closing square bracket (]) when searching for "Bracket" tokens.
readValFilterwas then updated to look for any dot after the closing bracket and a following "Word" token. When this happens an implicitandop is returned.One issue with this approach is that any
andops before or after this syntax will result in nestedandops instead of a single op with more than two filters. Check the last test added toparse.test.tsfor an example. However, I couldn't figure out a neat way to flattening that use case without a much more disruptive changeset.fixes: #96