Skip to content

Deep ecosystem integration #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Deep ecosystem integration #11

wants to merge 1 commit into from

Conversation

ethangreen-dev
Copy link
Member

No description provided.

@ethangreen-dev ethangreen-dev marked this pull request as ready for review January 21, 2025 08:43
ebkr
ebkr reviewed Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@ebkr ebkr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also be good to update the adding a game document if this affects how we currently add games.

schema.json Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we have everything included?

Things like categories aren't necessary and don't need to be in here imo. It's a prime target for becoming out of sync and I'd imagine won't actually be used by us anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For simplicity mostly. Otherwise we would need to have an additional build step with prunes all unnecessary fields which doesn't seem to offer much for the increase in complexity. This will be mostly ameliorated when we implement runtime schema updates.

anttimaki
anttimaki reviewed Jan 22, 2025
View reviewed changes
Copy link

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the parts where there were many consecutive red lines.

@anttimaki
Copy link

Also related to some of @ebkr's comments and some of mine, we might want to refactor the enums in the r2mm codebase to a) be consistent b) use values that can be more easily matched with the values from ecosystem, while keeping them somewhat generic to avoid any weirdly specific names in the ecosystem that mean nothing outside the context of the mod manager.

If we decide to go that way, would probably make sense to do that before these changes?

@ethangreen-dev ethangreen-dev force-pushed the deep-ecosystem-integration branch from 255975e to 5a25f21 Compare January 29, 2025 23:34
@ethangreen-dev
Integrate ecosystem-schema
be1215a 
This commit and PR largely aim to replace previously hard-coded game and
mod definitions within R2MM with data read directly from the
ecosystem schema (thunderstore-io/ecosystem-schema).

Validation is accomplished through ajv, which allows us to validate the
provided ecosystem-schema document with its cooresponding JSON schema
(ecosystem.json and ecosystemJsonSchema.json).
@ethangreen-dev ethangreen-dev force-pushed the deep-ecosystem-integration branch from 5a25f21 to be1215a Compare January 29, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttimaki anttimaki anttimaki left review comments

@ebkr ebkr ebkr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethangreen-dev @anttimaki @ebkr