You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You can control the life-cycle of PRs via "blessings", which are implicit operations done without providing a review that can be misinterpreted as an expert review.
41
+
42
+
> TL;DR:
43
+
> * To dismiss a PR in "Needs Maintainer Review", move it to "Waiting for Code Reviews".
44
+
> * To dismiss a PR in "Needs Maintainer Action", move it to "Waiting for Author to Merge".
45
+
> * To undo either of these, move them to any other column.
46
+
47
+
* If a PR requires a *maintainer review*, you can fulfill this requirement by a "review-blessing": you do that by moving the PR to the `Waiting for Code Reviews` column (using the drop-down in the "Projects" section on the right).
48
+
This is especially relevant in cases where a maintainer review is needed because of a technical requirement like no tests, suspicious config edits etc: in such cases you can review-bless the PR in case the config edit is fine, the change is small or doesn't modify types etc.
49
+
Note that it only dismisses the maintainer review requirement, so the PR will continue the usual flow, and will wait for approvals as needed.
50
+
51
+
* If a PR requires a *maintainer action*, you can move it to the `Waiting for Author to Merge` column to "merge-bless" it: make the bot offer the author to self-merge.
52
+
This is particularly useful in cases where a PR author is unsure about something, and is trying to solicit review from owners or library authors: it makes it possible to defer the decision when to merge to the author, instead of starting an "are you ready" discussion.
53
+
54
+
You can use either of these blessings in other cases too, the above are just the common use cases. A review-blessing is only good to satisfy a maintainer review requirment (so other reviews will be needed), and a merge-blessing will usually make a PR self-mergable, but it will still wait until a PR is unconflicted and the CI is green.
55
+
56
+
Like a review, both kinds of blessings will be dismissed if the PR is updated.
57
+
You can also undo a blessing by moving a PR to any other column.
58
+
59
+
53
60
##### Amending an existing Definitely Typed Package
0 commit comments