Skip to content

Should coord_trans be renamed to coord_transform for API consistency? #5825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidhodge931 opened this issue Apr 3, 2024 · 2 comments · Fixed by #6046
Closed

Should coord_trans be renamed to coord_transform for API consistency? #5825

davidhodge931 opened this issue Apr 3, 2024 · 2 comments · Fixed by #6046
Labels
coord 🗺️ tidy-dev-day 🤓 Tidyverse Developer Day

Comments

@davidhodge931
Copy link

No description provided.

@teunbrand
Copy link
Collaborator

I'm not against this, but if it is renamed we should keep coord_trans() around for backward compatibility.

The following is tangential to this particular issue. As #5821 also calls for renaming stuff, we might want to think about lifecycles of renamed functions for the future (perhaps also for {scales} palettes/transformations/label/break functions). I imagine at a certain point we might want to start discouraging using the old names of functions. The lifecycle guidance all requires changes to the function body, which is inconvenient when functions are synonyms defined as:

new_name <- function(...){...}
old_name <- new_name

@teunbrand
Copy link
Collaborator

I'm proposing this for tidy dev day

@teunbrand teunbrand added coord 🗺️ tidy-dev-day 🤓 Tidyverse Developer Day labels Apr 15, 2024
nmercadeb added a commit to nmercadeb/ggplot2 that referenced this issue Aug 15, 2024
teunbrand added a commit that referenced this issue May 19, 2025
* rename coord_trans to coord_transform, issue #5825

* Update _pkgdown.yml

* add deprecated function to pkgdown

* revert NEWS.md revision

* simplify alias

* class alias

* reoxygenate

* remove duplicate news entries

---------

Co-authored-by: Teun van den Brand <[email protected]>
Co-authored-by: Teun van den Brand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coord 🗺️ tidy-dev-day 🤓 Tidyverse Developer Day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants