Skip to content

[PoC] Can we really use tibble internally? #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Dec 27, 2018

❗️ Do NOT MERGE THIS ❗️

This is an attempt to use tibble internally as discussed on #3018, but currently I feel this is going to be a tough job. Although this is still at the very early stage of work in progress, I already see several dificulties:

  • $.tbl_df warns when there is no such column. So, everytime we extract a column by $, we need to check if the name exists rather than check the result is NULL (c.f. 'unknown or uninitialised column' warning is annoying tibble#450).
  • Not all functions respect the tbl_df class. For example, transform() and cbind() returns data.frame. Besides, in some places the users can supply arbitrary functions, which meams we have to convert the result from those user-input functions to tibble very frequently. I'm afraid this not only does harm on performance, but also makes the code error-prone.
  • Many unexpected test failures...

@lock
Copy link

lock bot commented Jul 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant