return a tibble with ggplot_build() and layer_data()
#3264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, but this has been discussed on #3018 and declined. |
|
Oops, missed that one. I did actually benchmark it because I was aware of the performance changes, and it was only ~2 microsecs different on my machine, but that was very limited. I'll close this for now |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ggplot_build()andlayer_data()return adata.frame. This seems a little inconsistent with the rest of the tidyverse. This is little PR (motivated by some recent work withlayer_data()that filled up my console) changesggplot_build()to convert the data for the layers totibbles., which is also reflected inlayer_data().I also had to make a few tweaks to the tests due to some subtle differences with using a
tibble. However, I think these are mostly technical and that the spirit of each test is unchanged.