Add full support for ragg #4388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents in passed in device
clauswilke
reviewed
Mar 25, 2021
|
While you're at it, I would suggest to add at least the unit |
|
Yeah — px should at least be supported. I don't think pt has much merit as an output dimension unit? |
|
Normally my attitude would be "it doesn't cost much to add pt so why not" but I can see that people might get confused about the difference between px and pt so maybe better leave it out. |
|
Yeah, that is kinda my worry as well |
|
I've added px support - @clauswilke can you give this a review? |
clauswilke
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4347
This PR does two things: First, it will use ragg as the default device if it is installed when generating png, jpeg, and tiff files. Second, it fixes the issue that has crippled the use of
device = agg_pngin ggsave, in that it explicitly sets the resolution and units to use in the device function that is passed in. While this only works for devices that usesresandunitsarguments it means that devices that uses the same signature aspng()will work the same way