remove_missing() considers characters as finite
#5188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
changed the title
remove_missing() considers characters as finite
teunbrand
commented
Feb 14, 2023
| @@ -90,7 +90,7 @@ remove_missing <- function(df, na.rm = FALSE, vars = names(df), name = "", | |||
| missing <- detect_missing(df, vars, finite) | |||
|
|
|||
| if (any(missing)) { | |||
| df <- df[!missing, ] | |||
| df <- df[!missing, , drop = FALSE] | |||
There was a problem hiding this comment.
This shouldn't occur in wild plotting because there should always be multiple columns. However, since it came up in testing, I thought to change this too.
There was a problem hiding this comment.
Agreed - I think we should aim to make the code as clear and type stable as possible
|
Thanks for another review Thomas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #4284.
Briefly,
remove_missing()now considers character vectors as finite (unless they'reNA).This makes it easier to have required aesthetics that are not numeric in custom Stats subclasses.