Skip to content

New coord_cartesian(ratio) argument #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 20, 2025

Conversation

teunbrand
Copy link
Collaborator

This PR implements a proposal in #6389 (comment).

Briefly, we incorporate the ratio logic in coord_cartesian() so that we can supersede coord_fixed() and coord_equal().

@teunbrand teunbrand added this to the ggplot2 4.0.0 milestone May 7, 2025
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should supersede these functions, but perhaps they should just be shortcut constructors for CoordCartesian?

@teunbrand
Copy link
Collaborator Author

Right, so we just change the phrasing in the news bullet?

@thomasp85
Copy link
Member

That, and remove the superseded badges etc

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 7fb5760 into tidyverse:main May 20, 2025
13 checks passed
@teunbrand teunbrand deleted the absorb_coord_fixed branch May 20, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants