This repository was archived by the owner on Apr 4, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 140
[WIP] Reactive rerendering #282
Closed
Closed
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ba63f61
Add ability for templates to reuse morphs
7d7aa98
Encapsulate state needed for re-render
d65b07c
Extract static cached fragment logic to runtime
tomdale a3d7112
Break apart hydration code into phases
tomdale b3730bd
Introduce element morphs
tomdale 2b0312f
Fix failing tests
tomdale 1066f32
renderNodes -> buildRenderNodes
fe8096e
Too many hooks.
97f0caf
Guard if no parent and no contextualElement
81b787a
Expose public API for easy rerendering
ddccc30
Block helpers mutate in place rather than return
de981e2
Rename rerender to revalidate
2fd475f
Simplify template rendering in block helpers
ff0dfea
Propagate ownerNode through the render nodes
61a2fe9
Maintain consistent “shape” for options hash
7098b6b
`get` helper should get render node for dirtying
13b8337
Introduce dirtiness to render node invalidation
1ce5d4a
Defer more of rendering to the runtime
wycats 2ecb7e6
Remove unnecessary inlined render function
wycats cf27996
Use extracted morph-range library
5a223d1
Ensure templates always have stable boundaries
4082379
Clean up scope handling
wycats 5c06422
Make ordering of scope/env consistent
wycats 613babc
Tighten up argument order
fe711cc
Provide `this.yield` sugar in block helpers
4ee6315
Hooks don't need to understand contextualElement
e836007
Start writing host hook documentation
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be importing from
htmlbars-runtime
from withinhtmlbars-compiler
for anything other than tests (the runtime is not available within Ember for example). If the wrap function needs to be shared and available to compiler (and ultimately to the consuming library) it should be inhtmlbars-utils
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. If
utils
is imported into bothruntime
andcompiler
, that's the right place for this for sure.