Add a GitHub workflow definition #156
Conversation
|
Side note for lurkers: to build the installer for the latest Git, just uncomment the |
|
@timcharper gentle ping? |
|
@timcharper another gentle ping? Would be nice to get this going in time for Git v2.27.0... |
|
@dscho thanks for your work, I'm loving this new GitHub Action! |
|
@timcharper hi there! Long time no hear. Any news from your side? |
There was a problem hiding this comment.
Hey, @timcharper sorry if this is bothering you but do you mind taking a look at this PR? (@dscho is the maintainer for git-for-windows in case you're not aware).
dscho
force-pushed
the
github-workflow
branch
2 times, most recently
from
3cdbddb to
c8cbf2d
Compare
It is really convenient to be able to use GitHub Actions to run automated tasks, such as creating the Git for macOS installer. This adds a GitHub workflow definition to do exactly that. It can be triggered manually from the Actions tab of the `git_osx_installer` repository on GitHub. For details, see https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch Alternatively, the `push:` line can be uncommented so that a simple push triggers the workflow. Signed-off-by: Johannes Schindelin <[email protected]>
With this change, we do not have any hard-coded fallback for the ref anymore, but always build the latest available tagged Git version. Signed-off-by: Johannes Schindelin <[email protected]>
| CFLAGS: -I/usr/local/opt/gettext/include | ||
| # Link with cURL | ||
| CURL_LDFLAGS: -lcurl | ||
| # To make use of the catalogs... |
There was a problem hiding this comment.
Instead of # To make use of the catalogs..., I suggest a more detailed wording:
Catalogs are required to build man. These are installed through docbook [1] and docbook-xsl [2] dependencies of asciidoc in homebrew.
[1] https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/asciidoc.rb#L27
[2] https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/asciidoc.rb#L26
|
I couldn't get this Github Action to work for me. Running it failed in the "Bundle .dmg" task with the error: Weirdly enough I was running the action on macos-latest wich is MacOS 12 so I really don't understand why this issue occurs. Any help would be greatly appreciated. Attached are the logs to the failed build runs on my fork. |
This error probably means that you would have to adjust https://github.com/timcharper/git_osx_installer/pull/156/files#diff-de90736762a5cf22e0cbc7531a25565f2b3a90c2e741616362a4c8d4bc4fa950R29 a bit. As it stands, however, I cannot justify to keep this Pull Request open. There has been exactly 0 feedback from the maintainer of this repository, and my intention was to leverage the maintainer's expertise to avoid duplicating efforts in |
With this PR, it should be a lot easier to build new installers. An example build can be found here.
Please note that this PR only builds unsigned installers for now. If this experiment goes well, we should probably look into integrating both a signing step as well as a step to upload the result to SourceForge (using their API), both contingent on the respective credentials being available as GitHub Action secrets.