Remove experimental flag modern: true #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature got dropped by Next.js so should be removed, see: vercel/next.js#19275
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/timlrx/tailwind-nextjs-starter-blog/A8gJhLRem1eRiEQ7zADT12ZCapeg |
|
Thanks, I see that next.js 10.1 has upgraded to webpack 5. You probably encountered an error since you mentioned in a previous post that you deleted package-lock.json and re-installed it. I Will merge this together will the next version upgrade. |
|
updated in #14 and use webpack 5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature got dropped by Next.js so should be removed, see: vercel/next.js#19275
Arguably, it could still be worth keeping (people mention 3-6% bundle size improvement, 21% bundle size improvement when using Preact), but it's a bit of a landmine.
I haven't actually compared bundle sizes or looked at the effect of this change. What do you think @timlrx?
As discussed in that pull request over at Next.js, it's incompatible for when they migrate to Webpack 5. I think removing this feature is currently in the /canary version of Next.js, not a released version.