Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the strings 'for' and 'while' in function #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

koddsson
Copy link

Fixes #119 by checking the given function for the strings "while" or "for". It has the obvious drawback of failing if the mere string is present.

Not sure if this is the best solution but I thought at least it would get a dialog started on how to fix this issue.

@timoxley
Copy link
Owner

timoxley commented Nov 15, 2016

Ideally we'd parse their solution into an AST and check for loop constructs that way… but this perhaps solves it the most simple way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async Loops verify process maybe incorrect.
2 participants