fix pause handling implementation on the controllers #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulbabu95
commented
Apr 30, 2025
Update pause handling in both cluster and machine controllers to pause further reconciliation when the capi cluster is paused. Signed-off-by: Rahul Ganesh <[email protected]>
rahulbabu95
force-pushed
the
fix/skip-reconcile-reboot-workflow
branch
from
d44b182 to
8ad3f83
Compare
Signed-off-by: Rahul Ganesh <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR improves pause handling in the Tinkerbell controllers to prevent unwanted reconciliation during cluster moves. The changes include:
- Adding cluster lookup and pause annotation checks in the machine controller.
- Reordering logic in the machine controller to incorporate pause validation.
- Introducing pause annotation checks in the cluster controller.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| controller/machine/tinkerbellmachine.go | Adds cluster lookup with pause checking; note the reordering of deletion logic. |
| controller/cluster/tinkerbellcluster.go | Introduces pause annotation checks with a TODO for future enhancement regarding pause handling. |
jacobweinstock
approved these changes
Apr 30, 2025
jacobweinstock
added
ready-to-merge
jacobweinstock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cluster-API version (>=1.9.5) incorporated a fix for a race condition in their clusterctl move logic. Currently, during a cluster move operation, CAPT controllers interpret the temporary absence of TinkerbellMachine CRDs in the source cluster as a deletion event. This triggers power-off jobs, potentially causing catastrophic effects for users, when in reality the resources are just being moved from source to target cluster.
This PR implements proper pause handling in both cluster and machine controllers to prevent unwanted reconciliation during cluster move operations. When a CAPI cluster is paused:
Why is this needed
Fixes: #
How Has This Been Tested?
Tested with a custom built controller and moving the CRs back and forth using clusterctl move.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: