Skip to content

Add autocomplete and --list option for listing commands (#69) #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2020

Conversation

wcheang
Copy link
Contributor

@wcheang wcheang commented Jul 18, 2020

Closes #69

Hi! I was interested in the autocomplete feature, so I took a stab at implementing it. It didn't take much extra effort to add a --list option to list available commands for the platform, so I did that as well, seeing that the node client has one. I'm pretty new to contributing to opensource projects, so any suggestions are greatly appreciated :)

argcomplete was acting a little bit finicky on my local dev environment, so it'll be great if one of the maintainers can try it out to make sure it works fine as well.

Thank you for this great client!

@MasterOdin
Copy link
Collaborator

Thanks for the awesome patch and enabling autocompletion! It's one of the final big missing pieces for this client compared to the node one. Some minor critiques above, but the overall gist of it is spot-on!

@wcheang
Copy link
Contributor Author

wcheang commented Jul 21, 2020

I think all the comments should be addressed. @MasterOdin would you please have another look? Thanks!

@MasterOdin MasterOdin merged commit d273fcd into tldr-pages:master Jul 23, 2020
@MasterOdin
Copy link
Collaborator

Thanks again for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocompletion for shells
2 participants