Add autocomplete and --list option for listing commands (#69) #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterOdin
requested changes
Jul 18, 2020
|
Thanks for the awesome patch and enabling autocompletion! It's one of the final big missing pieces for this client compared to the node one. Some minor critiques above, but the overall gist of it is spot-on! |
Co-authored-by: Matthew Peveler <[email protected]>
|
I think all the comments should be addressed. @MasterOdin would you please have another look? Thanks! |
MasterOdin
approved these changes
Jul 22, 2020
|
Thanks again for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69
Hi! I was interested in the autocomplete feature, so I took a stab at implementing it. It didn't take much extra effort to add a --list option to list available commands for the platform, so I did that as well, seeing that the node client has one. I'm pretty new to contributing to opensource projects, so any suggestions are greatly appreciated :)
argcomplete was acting a little bit finicky on my local dev environment, so it'll be great if one of the maintainers can try it out to make sure it works fine as well.
Thank you for this great client!