Skip to content

get remote resource only after all cache failed #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 1, 2021
Merged

get remote resource only after all cache failed #151

merged 5 commits into from
Feb 1, 2021

Conversation

ramwin
Copy link
Contributor

@ramwin ramwin commented Jan 4, 2021

No description provided.

@ramwin ramwin mentioned this pull request Jan 4, 2021
Closed
MasterOdin
MasterOdin requested changes Jan 4, 2021
View reviewed changes
Copy link
Collaborator

@MasterOdin MasterOdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've made some review comments to resolve, and then I think we can merge this.

ramwin and others added 2 commits January 4, 2021 22:39
@ramwin @MasterOdin
Apply suggestions from code review
f968fce 
* format style
* change else if to elif

Co-authored-by: Matthew Peveler <[email protected]>
@ramwin
wrap USE_CACHE to avoid wasted cycles
612da30
@ramwin
Copy link
Contributor Author

ramwin commented Jan 4, 2021

Thank you for your advises, I accept all of them.

@ramwin
code format
12f9d0b 
* format the code style
* combine the elif statement
ramwin
ramwin commented Jan 5, 2021
View reviewed changes
Copy link
Contributor Author

@ramwin ramwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your advises, I accept all of them.

@ramwin ramwin requested a review from MasterOdin January 5, 2021 02:03
@bl-ue
Copy link
Contributor

bl-ue commented Jan 31, 2021

@MasterOdin will you please review this again? Thank you.

@MasterOdin MasterOdin merged commit 20624de into tldr-pages:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterOdin MasterOdin MasterOdin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramwin @bl-ue @MasterOdin