ci: drop support for Python 3.6 #201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenvoke
force-pushed
the
feature/python-3.6
branch
from
71d2127 to
a637702
Compare
|
Seems like the build fails now too. |
|
Looks like it's failing because the tests are expecting single quotes in output, whereas they are being given double quotes? 👀 |
Oh 👀 , Edit: This makes sense see #203 |
|
Actually, that might be irrelevant. 🤷🏻 I will see if I can bump pytest when I get home and see if that helps. |
|
Nice, The CI passed 🥳 |
|
Looks like my changes have been applied separately, so closing this PR 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also bumped
actions/checkoutandactions/setup-pythonto the latest versions. 👍🏻I don't know enough about Python to know why the tests are failing, however. 👀