fix: pytest usage in CI #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing a deprecated command)
owenvoke
approved these changes
Oct 3, 2024
spageektti
approved these changes
Oct 3, 2024
sebastiaanspeck
approved these changes
Oct 4, 2024
kbdharun
approved these changes
Oct 4, 2024
|
No worries, thanks for welcoming my PRs. I've used https://tldr.sh/ a bunch in the past, so more than happy to give back even in such a small way 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255
This should fix the error by not invoking the tests via setup.py, instead using
pytestdirectly as per their docs.I've also made two small cleanups while in the area:
python3instead ofpythonfor consistency within the rest of thetest.ymlfile.test_get_commandstest (see screenshots for before/after).Before:
After:
This should be enough to get the GHA builds green again on
main✅