-
-
Notifications
You must be signed in to change notification settings - Fork 101
feat/ci: use commit hash for actions, add arm64 support to test workflow #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: K.B.Dharun Krishna <[email protected]>
Signed-off-by: K.B.Dharun Krishna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no experience with these systems, thus my approval is very useless. I glanced at the changes and they're looked probably ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One query, I assume Dependabot won't update the version comments next to the commits? 🤔 If not, then they will probably get outdated pretty quickly unless we manually update the comments for each Dependabot PR.
Actually Dependabot takes care of updating the version comments too, checkout https://github.blog/changelog/2022-10-31-dependabot-now-updates-comments-in-github-actions-workflows-referencing-action-versions/ while it's not clearly mentioned in docs, I have seen it working in other projects using commit SHA for actions. Checkout tldr-pages/tldr#15947 for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I didn't know that, and that's pretty cool. 🙌🏻
Implemented ARM support for building snaps too. I will update the build-snap job to be dependent on build job's completion so that if something in a PR is broken and is reflected in the build then no need to build snap to confirm the same (this will save a few minutes from workflow runs assisting in faster debugging/review process). |
Changes
snapcore/action-build
tocanonical/action-build
since the latter one is the base repo and snapcore one is a fork.