Skip to content

feat/ci: use commit hash for actions, add arm64 support to test workflow #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2025

Conversation

kbdharun
Copy link
Member

@kbdharun kbdharun commented Mar 26, 2025

Changes

  • This PR switches all version based rewritable action tags to use commit hashes instead.
  • Dependabot frequency for GitHub action update check has been changed to “weekly” to incorporate point releases quickly (since we are using hash based approach from now).
  • Add GitHub's free partner arm runner (currently in public preview) to build job in test workflow to test the code changes in arm64 too along with amd64.
  • I have renamed snapcore/action-build to canonical/action-build since the latter one is the base repo and snapcore one is a fork.

Copy link
Contributor

@Managor Managor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no experience with these systems, thus my approval is very useless. I glanced at the changes and they're looked probably ok.

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One query, I assume Dependabot won't update the version comments next to the commits? 🤔 If not, then they will probably get outdated pretty quickly unless we manually update the comments for each Dependabot PR.

@kbdharun
Copy link
Member Author

kbdharun commented Mar 27, 2025

One query, I assume Dependabot won't update the version comments next to the commits? 🤔 If not, then they will probably get outdated pretty quickly unless we manually update the comments for each Dependabot PR.

Actually Dependabot takes care of updating the version comments too, checkout https://github.blog/changelog/2022-10-31-dependabot-now-updates-comments-in-github-actions-workflows-referencing-action-versions/ while it's not clearly mentioned in docs, I have seen it working in other projects using commit SHA for actions.

Checkout tldr-pages/tldr#15947 for more information.

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I didn't know that, and that's pretty cool. 🙌🏻

@kbdharun
Copy link
Member Author

Implemented ARM support for building snaps too.

I will update the build-snap job to be dependent on build job's completion so that if something in a PR is broken and is reflected in the build then no need to build snap to confirm the same (this will save a few minutes from workflow runs assisting in faster debugging/review process).

@kbdharun
Copy link
Member Author

Done, implemented it. Now the PR is GTG.


Adding some screenshots for future reference:-

Before:

image

After:

image
image

@kbdharun kbdharun merged commit bb2be0c into main Mar 27, 2025
34 checks passed
@kbdharun kbdharun deleted the fu/ci branch March 27, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants