-
Notifications
You must be signed in to change notification settings - Fork 163
Auto saves mess double saving panes and so restore is messed up?! #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey, thank you for reporting this issue. Do you have the latest versions of both What is your About "double" saving - that could happen if
I think I addressed this possibility, but I will look into this again. |
Hi,
I couldn't notice anything unusual with the "continuum" I've also inspected the code and after the first review I think we have mechanism in place that should prevent multiple saves happening at the same time.. So, can you please fetch latest One other thing I noticed about your |
But I got the same result as before when the first continuum auto save takes place :(
the dir name has a space in it. E.g. I have no other idea what can break continuum auto save. I thought of strange session names or so, but then resurrect should also fail. |
Hi, I also am experiencing the same problem. Every now and then I get triplicate entries the autosave file. This can be a real issue if this file is used by resurrect to recover a session. The worst case is when a vim session is recovered, the addition lines are send to vim and that can mess up a code file/document. in the I have made the following changes: The end of my .tmux.conf: set -g @resurrect-processes 'vifm ssh' Save every thirty minutesset -g @continuum-save-interval '30' |
Fixes the case where multiple tmux sessions call auto-save at the same time, which occasionally results in multiple instances of save_all() running in parallel and causing issues like #3 and tmux-plugins/tmux-resurrect#294. The sequence in main() is: 1. Check enough_time_since_last_run_passed 2. Save 3. Update last_save_timestamp. The race here is: * process A finishes step 1 and is busy with step 2. The timestamp is not updated yet. * process B comes to step 1, sees the old timestamp and proceeds to step 2, too.
We likely fixed this problem via #61. I'll close the issue now. If anyone reproduces this same problem again, please reopen. |
I'm not really sure where the bug lies :( Since I use tmux-continuum with conjunction of tmux-resurrect my apps not restored. What I see is that there are panes more than one time after a continuum save, probably this is the error for not restoring apps anymore.
Here is an example. Saved lines for a session with manual resurrect save:
And here the lines after continuum save:
Here are the attatched files:
manual save:
continuum save:
tmux conf:
The text was updated successfully, but these errors were encountered: