Skip to content

No implicit exports from __init__.py #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ssbarnea opened this issue Mar 1, 2024 · 1 comment · Fixed by #531
Closed

No implicit exports from __init__.py #530

ssbarnea opened this issue Mar 1, 2024 · 1 comment · Fixed by #531

Comments

@ssbarnea
Copy link
Contributor

ssbarnea commented Mar 1, 2024

As https://github.com/tmux-python/libtmux/blob/master/src/libtmux/__init__.py we can see some imports that are not mentioned inside an __all__ line.

This is is causing type check failures when running mypy in strict mode as it means that these module do not have an explicit exports. Example:

error: Module "libtmux" does not explicitly export attribute "Server"  [attr-defined]
ssbarnea added a commit to ssbarnea/libtmux that referenced this issue Mar 1, 2024
@ssbarnea
Add implicit exports into __init__.py
765d700 
Fixes: tmux-python#530
@ssbarnea ssbarnea mentioned this issue Mar 1, 2024
Merged
@tony tony closed this as completed in #531 Mar 2, 2024
tony pushed a commit that referenced this issue Mar 2, 2024
@ssbarnea
packaging: Add implicit exports into __init__.py (#531)
5a46a9a 
Fixes: #530
@tony
Copy link
Member

tony commented Mar 2, 2024

@ssbarnea #531 is live in v0.32.0 (PyPI, release notes, changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add implicit exports into __init__.py ssbarnea/libtmux
2 participants
@tony @ssbarnea