when uploading file to signed url, content-length is required unless … #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogishbaliga
force-pushed
the
yogish/fix-upload-file
branch
from
57a9a72 to
f41e6cb
Compare
…it is multi-part upload which is uploading files in multiple parts and then combining it at the end
yogishbaliga
force-pushed
the
yogish/fix-upload-file
branch
from
f41e6cb to
f6c8035
Compare
|
@Nutlope whenever you have sometime, please review this. |
|
@Nutlope can you review this PR when you get time ? |
|
@yogishbaliga sorry for the delay here! Your changes didn't work unfortunately, the file is not uploaded. I added a test in the examples folder where you should be able to see the contents of the file if it did work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…it is multi-part upload which is uploading files in multiple parts and then combining it at the end