Skip to content

Cleanup #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 7, 2021
Merged

Cleanup #141

merged 8 commits into from
Aug 7, 2021

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Aug 6, 2021

Commit descriptions should explain all changes :)

Fixes #115.

jplatte added 8 commits August 6, 2021 13:14
Makes `cargo check` work without extra flags.
crates.io will link to the right version on docs.rs automatically.
Older versions weren't actually working before.
MSRV is checked in test-versions.
CI will still ensure that intra-doc links that rely on these are not broken.
@jplatte
Copy link
Member Author

jplatte commented Aug 6, 2021

EDIT: Now I can't find the failure I'm talking about below in CI logs, but a different one. Looks like the suggested MSRV of 1.51 doesn't work either because axum currently relies on the IntoIterator implementation for arrays added in Rust 1.53. Restoring compatibility with 1.51 might be as easy as changing the affected parts of the code to use array::IntoIter explicitly (stabilized in 1.51). I'll leave that up to somebody else though.


This now removes one check from CI (second-to-last commit) but should be better than the status quo (due to #115).

This was necessary because cargo clippy on 1.51 failed because it didn't recognize msrv in .clippy.toml (of a dependency, hence removing axum's clippy config would not change anything).

@davidpdrsn
Copy link
Member

create_url_params is only called in tests. So changing the call sites to use a slice is fine.

Thanks for doing this by the way! Gonna review it over the next few days.

@davidpdrsn
Copy link
Member

I'm gonna merge this and fix CI on main. Would like to have this in when I start merging some of the many open PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI doesn't seems to not actually run for MSRV
3 participants