WIP: catch plugin loading failure #1817
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## rewrite #1817 +/- ##
===========================================
- Coverage 99.76% 99.73% -0.03%
===========================================
Files 133 133
Lines 7128 7133 +5
Branches 711 711
===========================================
+ Hits 7111 7114 +3
- Misses 6 8 +2
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gaborbernat
requested changes
Jan 13, 2021
| @@ -42,12 +43,16 @@ def __init__(self) -> None: | |||
| ) | |||
|
|
|||
| for plugin in internal_plugins: | |||
| logging.info("Registering %s", plugin) | |||
There was a problem hiding this comment.
I'd prefer to be silent if nothing bad happens.
| REGISTER.populate(self) | ||
| self.manager.check_pending() | ||
| except ImportError as e: | ||
| logging.warning("Ignored plugin %s which failed to load. %s", NAME, e) |
There was a problem hiding this comment.
Here you want %r to show the type too. And ideally, we'd also show the last source code line of the traceaback (you can get it via traceback.format_exc).
|
I'll close this now as it seems we'll not be able to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.