Force virtualenv and pip to output UTF-8 #2391
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1550.
This is an alternate take on #2390 that is better targetted to the specific
issue and may prove less risky overall.
After running these two commands with output redirected to a file, we
read said files with an explicit request for UTF-8 encoding. On some
cases this does not contain UTF-8 data. For example, on a French
Canadian Windows machine with non-ASCII characters in the username,
the output contains the contents of the
APPDATA
environmentvariable, which is printed to the current code page (
cp1252
).This change enables Python's "UTF-8 Mode" when running
virtualenv
and
pip
to guarantee the output is UTF-8 everywhere.Thanks for contributing a pull request!
If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rst
for example (588.bugfix.rst)<type>
is must be one ofbugfix
,feature
,deprecation
,breaking
,doc
,misc
-- by :user:`<your username>`.
CONTRIBUTORS
(preserving alphabetical order)