Remove usage of py.builtin #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis-ci is having a macos outage today, ok if I merge this? |
|
done :) |
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
==========================================
+ Coverage 93.63% 93.64% +<.01%
==========================================
Files 11 11
Lines 2358 2361 +3
==========================================
+ Hits 2208 2211 +3
Misses 150 150
Continue to review full report at Codecov.
|
| @@ -293,7 +295,10 @@ def initproj(request, tmpdir): | |||
| def initproj(nameversion, filedefs=None, src_root="."): | |||
| if filedefs is None: | |||
| filedefs = {} | |||
| if _istext(nameversion) or _isbytes(nameversion): | |||
| if ( | |||
There was a problem hiding this comment.
there is string_types for matching both
Merged
obestwalter
added a commit
that referenced
this pull request
Sep 10, 2017
as pointed out in #617 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #610
six(for use ofsix.text_type)py.builtin._totextwith explicit.decode(...)_istextand_isbyteswithisinstancedirectly (bytesis available in python2.6)py.builtin.print_withprint+from __future__ import print_functionpy.builtin.callablewith justcallable(available in python2.6)