Skip to content

fix(tracing): otel log level setup only for non-standalone processor #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

galkleinman
Copy link
Contributor

@galkleinman galkleinman commented Apr 29, 2025

Important

Moves OpenTelemetry log level setup in initialize() to occur only when tracing is enabled, preventing setup for standalone processors.

  • Behavior:
    • Moves OpenTelemetry log level setup inside the if block checking options.tracingEnabled in initialize() in index.ts.
    • Ensures log level setup only occurs when tracing is enabled, preventing setup for standalone processors.

This description was created by Ellipsis for 28e4165. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 28e4165 in 1 minute and 35 seconds. Click for details.
  • Reviewed 32 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/traceloop-sdk/src/lib/configuration/index.ts:82
  • Draft comment:
    Log level setup is now inside the tracingEnabled block. Ensure this is intentional, as logger configuration won’t occur if tracing is disabled.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. packages/traceloop-sdk/src/lib/configuration/index.ts:72
  • Draft comment:
    Removed diag.setLogger call from outside the tracing block. Ensure that it’s intended to skip OTEL logging when tracing is disabled.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
3. packages/traceloop-sdk/src/lib/configuration/index.ts:82
  • Draft comment:
    Diag logger is now initialized inside the tracingEnabled condition. Confirm that OTEL logging should only be set when tracing is enabled and update docs if needed.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_Md0HWP1Mynu7FBZC

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@galkleinman galkleinman merged commit f2e432f into main Apr 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants