Test PR - coverage comment #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
trallard
added a commit
to pydata/pydata-sphinx-theme
that referenced
this pull request
Mar 25, 2025
This PR _should_ be the last of a series of improvements to our CI: 1. We have been having intermittent failures on our `docs-check` workflow when trying to check links for `gnu` such as: ``` /home/runner/work/pydata-sphinx-theme/pydata-sphinx-theme/docs/community/topics/i18n.rst:112: WARNING: broken link: https://www.gnu.org/software/gettext/manual/gettext.html#Fuzzy-Entries (HTTPSConnectionPool(host='www.gnu.org', port=443): Max retries exceeded with url: /software/gettext/manual/gettext.html (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f6d203efb10>: Failed to establish a new connection: [Errno 101] Network is unreachable'))) ``` This PR tries to fix the timeout/retry issues. 2. Remove the RTD preview action that adds the link to the PR comment, as it has been failing despite having the correct permissions (and it seems RTD folks plan to move this to RTD directly readthedocs/readthedocs.org#11780) 3. Fixes the last trigger-related issues after changing the `coverage` workflow to `workflow_call` so we get our coverage comments again (I have a PR in my repo with this working again trallard#2) --------- Co-authored-by: Daniel McCloy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.