Skip to content

Failed to build on node 12 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gpetrov opened this issue Nov 24, 2019 · 2 comments
Closed

Failed to build on node 12 #13

gpetrov opened this issue Nov 24, 2019 · 2 comments

Comments

@gpetrov
Copy link

gpetrov commented Nov 24, 2019

Probably related to tree-sitter/node-tree-sitter#46

Getting errors like:

  ..\src\binding.cc(18): error : too few arguments to function call, single argument 'context' was not specified [node_modules\tree-sitter-html\build\tree_sitter_html_binding.vcxproj]
  ..\src\binding.cc(22): error : no matching member function for call to 'Set' [node_modules\tree-sitter-html\build\tree_sitter_html_binding.vcxproj]
  ..\src\binding.cc(23): error : no matching member function for call to 'Set' [\node_modules\tree-sitter-html\build\tree_sitter_html_binding.vcxproj]
@tcrowe
Copy link

tcrowe commented Nov 27, 2019

I too cannot build it and I am unsure why.

node -v
# v12.13.0
npm -v
# 6.12.0

Sample output

> node-gyp rebuild

  CC(target) Release/obj.target/tree_sitter_html_binding/src/parser.o
  CXX(target) Release/obj.target/tree_sitter_html_binding/src/scanner.o
  CXX(target) Release/obj.target/tree_sitter_html_binding/src/binding.o
../src/binding.cc:13:6: error: variable has incomplete type 'void'
void Init(Handle<Object> exports, Handle<Object> module) {
     ^
../src/binding.cc:13:11: error: use of undeclared identifier 'Handle'
void Init(Handle<Object> exports, Handle<Object> module) {
          ^
../src/binding.cc:13:18: error: 'Object' does not refer to a value
void Init(Handle<Object> exports, Handle<Object> module) {

@gpetrov
Copy link
Author

gpetrov commented Nov 27, 2019

Actually I manage to build it - just install the tree-sitter-cli globally and run it on the this main folder as:
tree-sitter generate

Actually the build is supposed to do this but I don't know why it doesn't run sometimes.

Maybe the owners here can commit the new generated cc files to solve the compile problem.
Actually just bindings.cc is changed and is the most important one

@amaanq amaanq closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants