Failed to build with node 12.1.0 #46

ProgramFan · 2019-05-07T15:41:59Z

npm install tree-sitter failed on macOS mojave 10.14.4, with the following errors:

> [email protected] install /Users/zyang/node_modules/tree-sitter
> prebuild-install || node-gyp rebuild

  CC(target) Release/obj.target/tree_sitter/vendor/tree-sitter/lib/src/lib.o
  LIBTOOL-STATIC Release/tree_sitter.a
  CXX(target) Release/obj.target/tree_sitter_runtime_binding/src/binding.o
  CXX(target) Release/obj.target/tree_sitter_runtime_binding/src/conversions.o

../src/conversions.cc:105:41: error: too few arguments to function call, single
      argument 'context' was not specified
  if (std::isfinite(js_row->NumberValue())) {
                    ~~~~~~~~~~~~~~~~~~~ ^
/Users/zyang/.node-gyp/12.1.0/include/node/v8.h:2564:3: note: 'NumberValue'
      declared here
  V8_WARN_UNUSED_RESULT Maybe<double> NumberValue(Local<Context> context) const;
  ^
/Users/zyang/.node-gyp/12.1.0/include/node/v8config.h:347:31: note: expanded
      from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/conversions.cc:106:52: error: too few arguments to function call, single
      argument 'context' was not specified
    row = static_cast<uint32_t>(js_row->Int32Value());
                                ~~~~~~~~~~~~~~~~~~ ^
/Users/zyang/.node-gyp/12.1.0/include/node/v8.h:2569:3: note: 'Int32Value'
      declared here
  V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
  ^
/Users/zyang/.node-gyp/12.1.0/include/node/v8config.h:347:31: note: expanded
      from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/conversions.cc:111:44: error: too few arguments to function call, single
      argument 'context' was not specified
  if (std::isfinite(js_column->NumberValue())) {
                    ~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/zyang/.node-gyp/12.1.0/include/node/v8.h:2564:3: note: 'NumberValue'
      declared here
  V8_WARN_UNUSED_RESULT Maybe<double> NumberValue(Local<Context> context) const;
  ^
/Users/zyang/.node-gyp/12.1.0/include/node/v8config.h:347:31: note: expanded
      from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/conversions.cc:112:58: error: too few arguments to function call, single
      argument 'context' was not specified
    column = static_cast<uint32_t>(js_column->Int32Value()) * BYTES_PER_...
                                   ~~~~~~~~~~~~~~~~~~~~~ ^
/Users/zyang/.node-gyp/12.1.0/include/node/v8.h:2569:3: note: 'Int32Value'
      declared here
  V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
  ^
/Users/zyang/.node-gyp/12.1.0/include/node/v8config.h:347:31: note: expanded
      from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/conversions.cc:130:47: error: too few arguments to function call, single
      argument 'context' was not specified
  return Nan::Just<uint32_t>(arg->Uint32Value() * BYTES_PER_CHARACTER);
                             ~~~~~~~~~~~~~~~~ ^
/Users/zyang/.node-gyp/12.1.0/include/node/v8.h:2567:3: note: 'Uint32Value'
      declared here
  V8_WARN_UNUSED_RESULT Maybe<uint32_t> Uint32Value(
  ^
/Users/zyang/.node-gyp/12.1.0/include/node/v8config.h:347:31: note: expanded
      from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
13 warnings and 5 errors generated.
make: *** [Release/obj.target/tree_sitter_runtime_binding/src/conversions.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:196:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:256:12)
gyp ERR! System Darwin 18.5.0
gyp ERR! command "/usr/local/Cellar/node/12.1.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/zyang/node_modules/tree-sitter
gyp ERR! node -v v12.1.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok

It seems that conversions.cc uses in-capatible v8 API?

The text was updated successfully, but these errors were encountered:

issue-label-bot · 2019-05-07T15:42:03Z

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Arcanemagus · 2019-05-07T16:26:24Z

You can follow the work on getting this running here: #45

mayankmit2002 · 2019-05-24T15:04:18Z

rebuild-install WARN install No prebuilt binaries found (target=12.1.0 runtime=node arch=x64 libc= platform=darwin)
CC(target) Release/obj.target/tree_sitter/vendor/tree-sitter/lib/src/lib.o
LIBTOOL-STATIC Release/tree_sitter.a
CXX(target) Release/obj.target/tree_sitter_runtime_binding/src/binding.o
CXX(target) Release/obj.target/tree_sitter_runtime_binding/src/conversions.o
../src/conversions.cc:32:12: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
exports->Set(Nan::New("pointTransferArray").ToLocalChecked(), Uint32Array::New(js_point_transfer_buffer, 0, 2));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
declarator attribute((deprecated(message)))
^
../src/conversions.cc:42:11: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
result->Set(Nan::New(start_position_key), PointToJS(range.start_point));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
declarator attribute((deprecated(message)))
^
../src/conversions.cc:43:11: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
result->Set(Nan::New(start_index_key), ByteCountToJS(range.start_byte));
I'm also facing similar issue on OSX Mojave 10.14.5

/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
declarator attribute((deprecated(message)))
^
../src/conversions.cc:44:11: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
result->Set(Nan::New(end_position_key), PointToJS(range.end_point));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
declarator attribute((deprecated(message)))
^
../src/conversions.cc:45:11: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
result->Set(Nan::New(end_index_key), ByteCountToJS(range.end_byte));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
declarator attribute((deprecated(message)))
^
../src/conversions.cc:68:3: warning: 'Get' is deprecated: Use maybe version [-Wdeprecated-declarations]
INIT(start_point, start_position_key, PointFromJS);
^
../src/conversions.cc:60:33: note: expanded from macro 'INIT'
auto field = Type(js_range->Get(Nan::New(key)));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:3412:3: note: 'Get' has been explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version", Local Get(Local key));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
declarator attribute((deprecated(message)))
^
../src/conversions.cc:69:3: warning: 'Get' is deprecated: Use maybe version [-Wdeprecated-declarations]
INIT(end_point, end_position_key, PointFromJS);
^
../src/conversions.cc:60:33: note: expanded from macro 'INIT'
auto field = Type(js_range->Get(Nan::New(key)));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:3412:3: note: 'Get' has been explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version", Local Get(Local key));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
declarator attribute((deprecated(message)))
^
../src/conversions.cc:70:3: warning: 'Get' is deprecated: Use maybe version [-Wdeprecated-declarations]
INIT(start_byte, start_index_key, ByteCountFromJS);
^
../src/conversions.cc:60:33: note: expanded from macro 'INIT'
auto field = Type(js_range->Get(Nan::New(key)));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:3412:3: note: 'Get' has been explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version", Local Get(Local key));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
declarator attribute((deprecated(message)))
^
../src/conversions.cc:71:3: warning: 'Get' is deprecated: Use maybe version [-Wdeprecated-declarations]
INIT(end_byte, end_index_key, ByteCountFromJS);
^
../src/conversions.cc:60:33: note: expanded from macro 'INIT'
auto field = Type(js_range->Get(Nan::New(key)));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:3412:3: note: 'Get' has been explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version", Local Get(Local key));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
declarator attribute((deprecated(message)))
^
../src/conversions.cc:80:11: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
result->Set(Nan::New(row_key), Nan::New(point.row));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
declarator attribute((deprecated(message)))
^
../src/conversions.cc:81:11: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
result->Set(Nan::New(column_key), ByteCountToJS(point.column));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version",
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
declarator attribute((deprecated(message)))
^
../src/conversions.cc:92:35: warning: 'Get' is deprecated: Use maybe version [-Wdeprecated-declarations]
Local js_row = js_point->Get(Nan::New(row_key));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:3412:3: note: 'Get' has been explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version", Local Get(Local key));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
declarator attribute((deprecated(message)))
^
../src/conversions.cc:98:38: warning: 'Get' is deprecated: Use maybe version [-Wdeprecated-declarations]
Local js_column = js_point->Get(Nan::New(column_key));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:3412:3: note: 'Get' has been explicitly marked deprecated here
V8_DEPRECATE_SOON("Use maybe version", Local Get(Local key));
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
declarator attribute((deprecated(message)))
^
../src/conversions.cc:105:41: error: too few arguments to function call, single argument 'context' was not specified
if (std::isfinite(js_row->NumberValue())) {
~~~~~~~~~~~~~~~~~~~ ^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:2564:3: note: 'NumberValue' declared here
V8_WARN_UNUSED_RESULT Maybe NumberValue(Local context) const;
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:347:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT attribute((warn_unused_result))
^
../src/conversions.cc:106:52: error: too few arguments to function call, single argument 'context' was not specified
row = static_cast<uint32_t>(js_row->Int32Value());
~~~~~~~~~~~~~~~~~~ ^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:2569:3: note: 'Int32Value' declared here
V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local context) const;
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:347:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT attribute((warn_unused_result))
^
../src/conversions.cc:111:44: error: too few arguments to function call, single argument 'context' was not specified
if (std::isfinite(js_column->NumberValue())) {
~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:2564:3: note: 'NumberValue' declared here
V8_WARN_UNUSED_RESULT Maybe NumberValue(Local context) const;
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:347:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT attribute((warn_unused_result))
^
../src/conversions.cc:112:58: error: too few arguments to function call, single argument 'context' was not specified
column = static_cast<uint32_t>(js_column->Int32Value()) * BYTES_PER_CHARACTER;
~~~~~~~~~~~~~~~~~~~~~ ^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:2569:3: note: 'Int32Value' declared here
V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local context) const;
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:347:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT attribute((warn_unused_result))
^
../src/conversions.cc:130:47: error: too few arguments to function call, single argument 'context' was not specified
return Nan::Just<uint32_t>(arg->Uint32Value() * BYTES_PER_CHARACTER);
~~~~~~~~~~~~~~~~ ^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8.h:2567:3: note: 'Uint32Value' declared here
V8_WARN_UNUSED_RESULT Maybe<uint32_t> Uint32Value(
^
/Users/mayankmittal/.node-gyp/12.1.0/include/node/v8config.h:347:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT attribute((warn_unused_result))

Is there workaround to go through it?

akurtakov · 2019-05-30T07:25:23Z

Any hope for this one? Can I help somehow?

mayankmit2002 · 2019-05-30T15:59:10Z

No success yet. It would be a great help if you can suggest some work around

maxbrunsfeld · 2019-05-30T19:40:17Z

Can I help somehow?

Yeah, I started work on this at #45, but have not had time to finish yet. If you're interested, feel free to work off of that branch.

It would be a great help if you can suggest some work around

The current workarounds are:

Do not use node 12
Use the WASM-based binding web-tree-sitter (which has almost the same interface) instead of this module.

See tree-sitter/node-tree-sitter#46 (comment) and bash-lsp/bash-language-server#131 (comment)

node-10 due to downstream bug with node-12 support (tree-sitter/node-tree-sitter#46)

skovhus · 2019-09-21T22:46:29Z

@maxbrunsfeld would you recommend that we start using tree-sitter-wasm instead of the node version in bash-language-server? Currently, we have more and more user upgrading to node 12.

Thanks for your help!

issue-label-bot bot added the bug label May 7, 2019

maxbrunsfeld changed the title ~~Failed to build on macOS with node 12.1.0~~ Failed to build with node 12.1.0 May 7, 2019

maxbrunsfeld mentioned this issue May 7, 2019

Node 12 doesn't compile tree-sitter/tree-sitter#325

Closed

pradeepvrd mentioned this issue May 9, 2019

Installation fails with node.js 12.x bash-lsp/bash-language-server#124

Closed

maxbrunsfeld mentioned this issue Jun 13, 2019

npm i web-tree-sitter :: fail on Node 12 tree-sitter/tree-sitter#362

Closed

zgeoff mentioned this issue Jun 16, 2019

add bash language server when downstream dependency works with node 12 zgeoff/dotfiles#120

Open

bmesuere mentioned this issue Jul 8, 2019

Tokenize with tree-sitter dodona-edu/dolos#8

Merged

KevOrr mentioned this issue Jul 12, 2019

Fix some operators' precedence/associativity tree-sitter/tree-sitter-php#38

Merged

jasonmorganson mentioned this issue Jul 14, 2019

Installation fails during compilation bash-lsp/bash-language-server#131

Closed

KevOrr added a commit to KevOrr/tree-sitter-php that referenced this issue Jul 15, 2019

Pin Node version to 11

ab7ee78

See tree-sitter/node-tree-sitter#46 (comment) and bash-lsp/bash-language-server#131 (comment)

KevOrr mentioned this issue Jul 15, 2019

Pin Node to v11 KevOrr/tree-sitter-php#1

Open

KevOrr added a commit to KevOrr/tree-sitter-php that referenced this issue Jul 15, 2019

Pin Node version to 11

cf24ddb

See tree-sitter/node-tree-sitter#46 (comment) and bash-lsp/bash-language-server#131 (comment)

KevOrr added a commit to KevOrr/tree-sitter-php that referenced this issue Jul 15, 2019

Pin Node version to 11

06e3f7e

See tree-sitter/node-tree-sitter#46 (comment) and bash-lsp/bash-language-server#131 (comment)

KevOrr added a commit to KevOrr/tree-sitter-php that referenced this issue Jul 15, 2019

Pin Node version to 11

dd91d72

See tree-sitter/node-tree-sitter#46 (comment) and bash-lsp/bash-language-server#131 (comment)

This was referenced Aug 6, 2019

CocInstall coc-sh installation fails with node 12.1 josa42/coc-sh#26

Closed

bash-language-server isn't downloaded, coc/sh/* folder stays empty josa42/coc-sh#24

Closed

patrickt pushed a commit to tree-sitter/tree-sitter-php that referenced this issue Aug 16, 2019

Pin Node version to 11

40e73b4

See tree-sitter/node-tree-sitter#46 (comment) and bash-lsp/bash-language-server#131 (comment)

patrickt mentioned this issue Aug 16, 2019

Pin Node version to 11 and port/remove unused unit tests tree-sitter/tree-sitter-php#40

Merged

Shados added a commit to Shados/nix-config-shared that referenced this issue Aug 22, 2019

pkgs: bash-language-server update, using node-10

47229fd

node-10 due to downstream bug with node-12 support (tree-sitter/node-tree-sitter#46)

rcjsuen mentioned this issue Aug 27, 2019

Your npm dependency cannot be installed with node 12.6.0 bash-lsp/bash-language-server#141

Closed

skovhus mentioned this issue Sep 21, 2019

Switch to tree-sitter-wasm (node 12 compatible) bash-lsp/bash-language-server#147

Merged

5 tasks

doronbehar mentioned this issue Sep 25, 2019

Install error Failed at the [email protected] install script bash-lsp/bash-language-server#93

Closed

drom mentioned this issue Oct 2, 2019

add export-scala-monitor sifive/duh-scala#39

Merged

maxbrunsfeld mentioned this issue Oct 22, 2019

Get the library working with node 12 #45

Merged

maxbrunsfeld closed this as completed in #45 Oct 22, 2019

gpetrov mentioned this issue Nov 24, 2019

Failed to build on node 12 tree-sitter/tree-sitter-html#13

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Failed to build with node 12.1.0 #46

Failed to build with node 12.1.0 #46

ProgramFan commented May 7, 2019

issue-label-bot bot commented May 7, 2019

Uh oh!

Arcanemagus commented May 7, 2019

Uh oh!

mayankmit2002 commented May 24, 2019

Uh oh!

akurtakov commented May 30, 2019

Uh oh!

mayankmit2002 commented May 30, 2019

Uh oh!

maxbrunsfeld commented May 30, 2019

Uh oh!

skovhus commented Sep 21, 2019

Uh oh!

Uh oh!

Failed to build with node 12.1.0 #46

Failed to build with node 12.1.0 #46

Comments

ProgramFan commented May 7, 2019

issue-label-bot bot commented May 7, 2019

Uh oh!

Arcanemagus commented May 7, 2019

Uh oh!

mayankmit2002 commented May 24, 2019

Uh oh!

akurtakov commented May 30, 2019

Uh oh!

mayankmit2002 commented May 30, 2019

Uh oh!

maxbrunsfeld commented May 30, 2019

Uh oh!

skovhus commented Sep 21, 2019

Uh oh!