Allow string prefixes to be either case #19
Merged
+38,414
−35,899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you add a test for at least one of these cases in the |
|
Done, but there is a CI failure that looks quite legitimate. Not sure what to do here. |
|
I think you just need to regenerate the parser by running the command ‘tree-sitter generate’. Then you should be able to recompile with ‘node-gyp build’ and run these tests with ‘tree-sitter test’. |
|
We check the generated code into the repo so that it is easy to use from languages other than JavaScript (which therefore can’t easily get the code from npm). |
|
Thanks for finishing this, @maxbrunsfeld, and sorry for not following up sooner. |
|
No worries! Glad to have this fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String prefixes in Python can be both small and capital case.
Tangentially related to tree-sitter/tree-sitter#130, although this is a "Type I" bug.