Skip to content

generate the crc32 lookup table at const time #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

folkertdev
Copy link
Collaborator

The real goal here is that we can figure out where the numbers came from.

The real goal here is that we can figure out where the numbers came from.
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
libbz2-rs-sys/src/crctable.rs 0.00% 20 Missing ⚠️
Files with missing lines Coverage Δ
libbz2-rs-sys/src/crctable.rs 0.00% <0.00%> (ø)

@folkertdev folkertdev requested a review from bjorn3 January 6, 2025 21:04
@bjorn3
Copy link
Collaborator

bjorn3 commented Jan 7, 2025

The fact that coverage is missing is caused by rust-lang/rust#73156.

@folkertdev folkertdev merged commit aecdb53 into main Jan 7, 2025
20 of 21 checks passed
@folkertdev folkertdev deleted the generate-crc-lookup-table branch January 7, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants