AWS CodeCommit source - avoid "for" loops #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoineco
reviewed
Jun 15, 2020
Comment on lines
250
to
253
| err := event.SetData(cloudevents.ApplicationJSON, v) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to set event data: %w", err) | ||
| } |
There was a problem hiding this comment.
Does it matter that the interface is asserted here? Can't we move that outside of the switch? SetData accepts interfaces.
| if err != nil { | ||
| return pullRequests, fmt.Errorf("failed to get PR info: %w", err) | ||
| } | ||
| //Get pull request IDs |
There was a problem hiding this comment.
A convention more than a written rule, but it's idiomatic to have a leading space for comments that are not meant to be consumed by machines (golang/go#37974 (comment)).
tzununbekov
force-pushed
the
codecommit-avoid-loop
branch
from
4cbf8e2 to
5550cb1
Compare
antoineco
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preparePullRequestsdoesn't haveforloop anymore:it's not explicitly documented, but it looks like
nextTokenin response is set only when we either specify list limit or there are more then 1000 items in list. However, our current loop break condition doesn't seem to do a correct check anyway and we're not hanging there forever only becausenextTokenis not used.sendPushEventandsendPREventfunctions merged into a singlesendEventwith event type assertionmentioned in #58